mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50252: Added native implementation for v1 Mesos interface.
Date Sat, 30 Jul 2016 01:30:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50252/#review144236
-----------------------------------------------------------




src/java/jni/org_apache_mesos_v1_scheduler_JNIMesos.cpp (line 282)
<https://reviews.apache.org/r/50252/#comment210233>

    since it is possible, i would just log a warning and ignore instead of crashing here?



src/java/jni/org_apache_mesos_v1_scheduler_JNIMesos.cpp (line 304)
<https://reviews.apache.org/r/50252/#comment210234>

    ditto.


- Vinod Kone


On July 29, 2016, 5:26 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50252/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Bugs: MESOS-5788
>     https://issues.apache.org/jira/browse/MESOS-5788
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the native C++ implementation for the v1
> Java class `JNIMesos` used for interacting with Mesos.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d 
>   src/java/jni/org_apache_mesos_v1_scheduler_JNIMesos.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50252/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message