mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.
Date Sat, 30 Jul 2016 00:00:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40512/
-----------------------------------------------------------

(Updated July 29, 2016, 5 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Changes
-------

Add authentication realms to method signature.


Bugs: MESOS-3820
    https://issues.apache.org/jira/browse/MESOS-3820


Repository: mesos


Description
-------

This builds upon earlier changes to complete `process::finalize`.  
Tests which need to reconfigure libprocess, such as some SSL-related 
tests, can use `process::reinitialize` to do so.  

This method may also be useful for providing additional isolation 
between tests, such as cleaning up all processes after each test case.


Diffs (updated)
-----

  3rdparty/libprocess/src/openssl.cpp a73313b3221d6c80b35f21c00f35d9f9c795f1ec 
  3rdparty/libprocess/src/process.cpp 7f331b812de2f0437838f48e0959441c8e04c358 

Diff: https://reviews.apache.org/r/40512/diff/


Testing
-------

TODO: Define `process::reinitialize` in several tests, such as `HTTPTest`, `MetricsTest`,
and `ReapTest` and call `process::reinitialize` before and after tests.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message