mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 40268: Libprocess Reinit: Change Socket::DEFAULT_KIND to a non-static value.
Date Fri, 29 Jul 2016 23:59:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40268/
-----------------------------------------------------------

(Updated July 29, 2016, 4:59 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Changes
-------

Tweak method and comment...


Bugs: MESOS-3820
    https://issues.apache.org/jira/browse/MESOS-3820


Repository: mesos


Description
-------

This is needed for tests that utilize the test-only 
`process::reinitialize` function.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/socket.hpp 881b44b987e5894cac838dae046ab7dbad20b000

  3rdparty/libprocess/src/socket.cpp 668f26d85cf3097ff9b90a10be14c5833fafd558 

Diff: https://reviews.apache.org/r/40268/diff/


Testing
-------

Some test cleanup issues were uncovered by this change; fixed here: https://reviews.apache.org/r/40453/


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message