mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.
Date Fri, 29 Jul 2016 23:56:03 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 29, 2016, 4:56 p.m.)

Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Comment tweak.

Bugs: MESOS-3934

Repository: mesos


The metrics singleton must be unified with `process::initialize` so 
that it also falls under the scope of reinitialization.  The singleton 
must also not be guarded by `Once`.

Diffs (updated)

  3rdparty/libprocess/include/process/metrics/metrics.hpp 54487ab2614c7f8e8df10d1e0c39880a6cf5bde3

  3rdparty/libprocess/src/metrics/metrics.cpp ac1544e70f5884f946ce3c31c5430c6a2c1f9dd1 
  3rdparty/libprocess/src/process.cpp 7f331b812de2f0437838f48e0959441c8e04c358 
  3rdparty/libprocess/src/tests/system_tests.cpp 0f4d0424689522337806ba2227ec4330c700e17e



Tests done in a subsequent review.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message