> On April 25, 2016, 3:55 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/process.cpp, line 1106
> > <https://reviews.apache.org/r/40266/diff/3/?file=1345267#file1345267line1106>
> >
> > Consider moving to `::finalize`. The unproxy code should mostly remain in-place.
Added another review (the next one) to address this.
> On April 25, 2016, 3:55 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 2036-2040
> > <https://reviews.apache.org/r/40266/diff/3/?file=1345267#file1345267line2036>
> >
> > Save `PID` and terminate via `PID`. This is a better guarantee against asynchronous/multiple
termination events.
Added another review (the next one) to address this.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40266/#review130502
-----------------------------------------------------------
On July 29, 2016, 4:44 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40266/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 4:44 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
>
>
> Bugs: MESOS-3910
> https://issues.apache.org/jira/browse/MESOS-3910
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `SocketManager` and `ProcessManager` are highly inter-dependent,
> which requires some untangling in `process::finalize`.
>
> * Logic originally found in `~ProcessManager` has been split into
> `ProcessManager::finalize` due to what happens during cleanup.
> * The future from `__s__->accept()` must be explicitly discarded as
> libevent does not detect a locally closed socket.
> * Terminating `HttpProxy`s must close the associated socket.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 7f331b812de2f0437838f48e0959441c8e04c358
>
> Diff: https://reviews.apache.org/r/40266/diff/
>
>
> Testing
> -------
>
> `make check` (libev)
> `make check` (--enable-libevent --enable-ssl)
>
>
> Thanks,
>
> Joseph Wu
>
>
|