mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.
Date Fri, 29 Jul 2016 21:13:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40512/#review144194
-----------------------------------------------------------




3rdparty/libprocess/src/process.cpp (line 863)
<https://reviews.apache.org/r/40512/#comment210199>

    s/programatically/programmatically/


- Greg Mann


On July 26, 2016, 9:17 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40512/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 9:17 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3820
>     https://issues.apache.org/jira/browse/MESOS-3820
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This builds upon earlier changes to complete `process::finalize`.  
> Tests which need to reconfigure libprocess, such as some SSL-related 
> tests, can use `process::reinitialize` to do so.  
> 
> This method may also be useful for providing additional isolation 
> between tests, such as cleaning up all processes after each test case.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/openssl.cpp a73313b3221d6c80b35f21c00f35d9f9c795f1ec 
>   3rdparty/libprocess/src/process.cpp 7f331b812de2f0437838f48e0959441c8e04c358 
> 
> Diff: https://reviews.apache.org/r/40512/diff/
> 
> 
> Testing
> -------
> 
> TODO: Define `process::reinitialize` in several tests, such as `HTTPTest`, `MetricsTest`,
and `ReapTest` and call `process::reinitialize` before and after tests.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message