mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 50518: Clarified log messages during master startup.
Date Fri, 29 Jul 2016 19:21:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50518/#review144162
-----------------------------------------------------------


Ship it!




Ship It!

- Anand Mazumdar


On July 27, 2016, 5:30 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50518/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In particular, it is confusing to have two separate log messages:
> "detected a new leader" and "elected as the new leader".
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
>   src/master/registrar.cpp 9d2f5580c7a8674f29b4c2be0142689f000d15a0 
> 
> Diff: https://reviews.apache.org/r/50518/diff/
> 
> 
> Testing
> -------
> 
> make check, visual inspection
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message