mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 50517: Reduced verbosity of version logging in executor/scheduler driver.
Date Fri, 29 Jul 2016 19:09:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50517/#review144157
-----------------------------------------------------------




src/exec/exec.cpp (line 161)
<https://reviews.apache.org/r/50517/#comment210173>

    Why this change? This is very useful when debugging to know the version of mesos the executable
was compiled against.
    
    Also, we dump the version information in a lot of other places too e.g., master, agent,
scheduler/executor library etc.


- Anand Mazumdar


On July 27, 2016, 5:29 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50517/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reduced verbosity of version logging in executor/scheduler driver.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp 90a16a904100eeee27969adf93091bcce253a98d 
>   src/sched/sched.cpp 6a1a201202b8241e853a821ffcec49187a5bdf35 
> 
> Diff: https://reviews.apache.org/r/50517/diff/
> 
> 
> Testing
> -------
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message