mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 50301: Reduced logging verbosity for replicated log operations.
Date Fri, 29 Jul 2016 19:01:15 GMT


> On July 29, 2016, 6:48 p.m., Anand Mazumdar wrote:
> > src/log/recover.cpp, line 466
> > <https://reviews.apache.org/r/50301/diff/2/?file=1455433#file1455433line466>
> >
> >     hmm, why did you reduce the verbosity here?

Do you think that is important to log? Note that this doesn't indicate anything unexpected
has happened.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50301/#review144148
-----------------------------------------------------------


On July 27, 2016, 5:29 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50301/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Logging the duration required for each storage operation at `INFO` level
> is overkill for most people consuming the log.
> 
> 
> Diffs
> -----
> 
>   src/log/leveldb.cpp f389d74b123574665c611b46cb52e3dc7042b331 
>   src/log/log.cpp f8e439fc756af05acb40878a9473c93c039c889e 
>   src/log/recover.cpp 69b5b28e5e680aa65a2166b06d3bdbd10c390903 
>   src/log/replica.cpp 45b77178fe93e26ae0ffde5ff0f02f36e5150bcb 
>   src/master/registrar.cpp 9d2f5580c7a8674f29b4c2be0142689f000d15a0 
> 
> Diff: https://reviews.apache.org/r/50301/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also visual inspection: ran a few `--verbose` test cases and checked that the omitted
information wasn't necessary/useful for understanding the replicated log activity.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message