mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 50601: Fixed Rakefile to generate links to external .md files.
Date Fri, 29 Jul 2016 10:26:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50601/#review144073
-----------------------------------------------------------


Ship it!




Ship It!

- Till Toenshoff


On July 29, 2016, 9:35 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50601/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 9:35 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-5862
>     https://issues.apache.org/jira/browse/MESOS-5862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously links to external .md -i.e, outside of the documentation-
> were generated incorrectly. This patch exludes all links to .md
> files starting with http from the link rewriting logic.
> Note that this includes https links.
> 
> 
> Diffs
> -----
> 
>   site/Rakefile aa777bdd8e459f27ab487b5641595142f4e14c68 
> 
> Diff: https://reviews.apache.org/r/50601/diff/
> 
> 
> Testing
> -------
> 
> build website via docker container.
> additionally regex explained/tested here: https://regex101.com/r/zP6sH6/3
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message