mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50064: Added setns and active user test binaries.
Date Thu, 28 Jul 2016 22:12:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50064/#review144011
-----------------------------------------------------------


Ship it!




LGTM!


src/tests/CMakeLists.txt (line 26)
<https://reviews.apache.org/r/50064/#comment209951>

    This TODO still seems relevant.  I'll add it back in before committing.


- Joseph Wu


On July 21, 2016, 11:37 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50064/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 11:37 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added setns and active user test binaries.
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
>   src/tests/cmake/MesosTestsConfigure.cmake caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf

>   src/tests/containerizer/CMakeLists.txt 41e792a2c9ec588d4897d60d012e67c606bbe601 
> 
> Diff: https://reviews.apache.org/r/50064/diff/
> 
> 
> Testing
> -------
> 
> cmake .. && make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message