mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre Cheynier ...@pierre-cheynier.net>
Subject Re: Review Request 50570: Mesos-slave --help should not return as failed.
Date Thu, 28 Jul 2016 17:24:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50570/
-----------------------------------------------------------

(Updated juil. 28, 2016, 5:24 apr├Ęs-midi)


Review request for mesos and Greg Mann.


Changes
-------

Add reviewer


Bugs: MESOS-5922
    https://issues.apache.org/jira/browse/MESOS-5922


Repository: mesos


Description
-------

Doing a `mesos-agent --help` should return with exit_status=0.
It's not the case since work_dir is considered as mandatory (1.0.0 / 95e6e3063c64ecdcf371181f98d0b2621be6186f)

Should fix MESOS-5922


Diffs
-----

  src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 

Diff: https://reviews.apache.org/r/50570/diff/


Testing
-------

$ ./boostrap
$ mkdir build && cd build
$ ../configure
$ make
$ make check
$ ./build/src/mesos-agent --help > /dev/null; echo $?
0
$ ./build/src/mesos-agent --work_dir='/mnt/mesos' > /dev/null; echo $?
0
$ ./build/src/mesos-agent --work_dir='/mnt/mesos' --master=localhost:5050; echo $?
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0728 17:01:43.261836 23247 main.cpp:243] Build: 2016-07-28 16:16:49 by pierre
I0728 17:01:43.261925 23247 main.cpp:244] Version: 1.1.0
I0728 17:01:43.261930 23247 main.cpp:251] Git SHA: beda6ffb72687d9f5c23b07552cadf42756bcd75
(...)


Thanks,

Pierre Cheynier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message