mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 50422: Future-proofed some slave removal tests.
Date Thu, 28 Jul 2016 10:14:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50422/
-----------------------------------------------------------

(Updated July 28, 2016, 10:14 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Address comments.


Repository: mesos


Description (updated)
-------

These tests relied on the implementation detail that when an agent is
removed from the list of registered agents, the master sends a
ShutdownSlaveMessage to the agent. That will change in the future
(MESOS-4049). To prepare for this future planned behavior, adjust these
tests to be more robust by instead checking for the invocation of the
`slaveLost` scheduler callback.


Diffs (updated)
-----

  src/tests/slave_tests.cpp b9fa85dc1ae0922a100786fcb01156b90a013d2a 

Diff: https://reviews.apache.org/r/50422/diff/


Testing
-------

make check

Validated that when the "cancel pending slave removal on receipt of ping" code is removed,
`CancelSlaveRemoval` still fails.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message