mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Re: Review Request 50417: Improved consistency of test code for partitioning an agent.
Date Thu, 28 Jul 2016 09:42:43 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 28, 2016, 9:42 a.m.)

Review request for mesos and Vinod Kone.


Update commit message.

Repository: mesos

Description (updated)

Removed unnecessary `Clock::settle` calls: `Clock::settle` should
typically only be used when a test case does not have an easy way to
wait for a _specific_ event to occur. In this case, `Clock::settle` was
unnecessary because the test code immediately proceeded to `AWAIT_READY`
for a more specific event.

Also fixed up some whitespace.

Diffs (updated)

  src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 
  src/tests/slave_recovery_tests.cpp 470fb26a2985f912b2b91d647cd7a27b8748c2a5 
  src/tests/slave_tests.cpp b9fa85dc1ae0922a100786fcb01156b90a013d2a 



make check


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message