mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 50235: Added more expectations to TASK_LOST test cases.
Date Thu, 28 Jul 2016 09:06:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50235/
-----------------------------------------------------------

(Updated July 28, 2016, 9:06 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Replaced more ASSERTs with EXPECTs per RR comments.


Bugs: MESOS-4049
    https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description (updated)
-------

Check the reason and source of TASK_LOST status updates, replaced
ASSERT_ with EXPECT_ in various places where EXPECT_ is more
appropriate.


Diffs (updated)
-----

  src/tests/fault_tolerance_tests.cpp 79f36a5a855ea1795be83840479e71f0e417298b 
  src/tests/master_authorization_tests.cpp e43b264b9f67d4cd965aee143cc42a1034ac9952 
  src/tests/master_maintenance_tests.cpp 2d4b45f78a234118df9e58a69f5587dd4d37956c 
  src/tests/master_slave_reconciliation_tests.cpp fdb9bb651c682fb302bb2a533d2dda9bf090839a

  src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
  src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 
  src/tests/slave_recovery_tests.cpp 470fb26a2985f912b2b91d647cd7a27b8748c2a5 

Diff: https://reviews.apache.org/r/50235/diff/


Testing (updated)
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message