mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yubo Li <liyub...@cn.ibm.com>
Subject Re: Review Request 50123: Added GPU scheduler for docker containerizer.
Date Thu, 28 Jul 2016 05:46:22 GMT


> On 七月 27, 2016, 11:16 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, lines 1305-1311
> > <https://reviews.apache.org/r/50123/diff/1/?file=1445669#file1445669line1305>
> >
> >     One question for this: I found that the `nvidia devices` was created as a `devices
string` here when `launchExecutorContainer` and then in https://reviews.apache.org/r/50125/
, the `devices string` was re-constructed when `launchTask`,why not construct the `docker
run` parameters for `nvidia devices` directly in `launchTask`?

The struct `Docker::Device` was created by Ben in a previous patch (https://reviews.apache.org/r/49579/)
so that I re-used this structure here. In my following patch https://reviews.apache.org/r/50128/,
I wrapped `Docker::Device::Parse()` and `Docker::Device::Serialize()` functions for string
from/to `Docker::Device` tranformations.


- Yubo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50123/#review143844
-----------------------------------------------------------


On 七月 18, 2016, 9:17 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50123/
> -----------------------------------------------------------
> 
> (Updated 七月 18, 2016, 9:17 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added 'NvidiaGpuAllocator' to docker containerizer so that the
> docker containerizer can use it to allocate GPUs to the task with 'gpus'
> resource. Also, allocated GPUs will automatically deallocated after the
> job destroyed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 
>   src/slave/containerizer/docker.cpp f1ecf3b25d85597f6c3dcaa47968860ed119dbd5 
> 
> Diff: https://reviews.apache.org/r/50123/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message