mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 50490: Moved ZooKeeperNetwork into separate hpp and cpp files.
Date Thu, 28 Jul 2016 05:18:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50490/
-----------------------------------------------------------

(Updated July 28, 2016, 5:18 a.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5828
    https://issues.apache.org/jira/browse/MESOS-5828


Repository: mesos


Description
-------

Moved ZooKeeperNetwork declaration into log/zookeeper/network.hpp
and definition into log/zookeeper/network.cpp.


Diffs (updated)
-----

  src/Makefile.am 3d33ee722543c67d0aa72e1c72c578066832331a 
  src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 
  src/log/log.cpp f8e439fc756af05acb40878a9473c93c039c889e 
  src/log/network.hpp 8750880e6cecb6edf4efab4f2b9afe3d8a4d5964 
  src/log/recover.cpp 69b5b28e5e680aa65a2166b06d3bdbd10c390903 
  src/log/zookeeper/network.hpp PRE-CREATION 
  src/log/zookeeper/network.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50490/diff/


Testing
-------

see the end of review chain


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message