mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.
Date Thu, 28 Jul 2016 02:00:25 GMT


> On July 28, 2016, 8:01 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 486
> > <https://reviews.apache.org/r/49827/diff/9/?file=1453251#file1453251line486>
> >
> >     Would love to understand why test will cause this issue.

It seems that comment was introduced by this ticket: https://issues.apache.org/jira/browse/MESOS-1438
, and in the test code here: https://github.com/apache/mesos/blob/1.0.0/src/tests/cluster.cpp#L552:L559
, I see each container created in the test will be cleaned up, and we have already initiated
cleanup for those containers in the test code, that might be where the race occurs.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49827/#review143861
-----------------------------------------------------------


On July 27, 2016, 1:11 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49827/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 1:11 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `CgroupsIsolatorProcess::cleanup`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp c57baec88437f68886702a40ec8a6a6458546119

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 348f105f9c3109a02f1dde0649f1b829cb9ddd04

> 
> Diff: https://reviews.apache.org/r/49827/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message