mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50491: Moved Network and NetworkProcess definitions into cpp file.
Date Wed, 27 Jul 2016 21:25:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50491/#review143811
-----------------------------------------------------------




src/log/network.hpp (lines 23 - 41)
<https://reviews.apache.org/r/50491/#comment209746>

    Can you clean up the headers here?
    The `.cpp` file should also include the appropriate headers (even if they are already
included here).


- Joseph Wu


On July 27, 2016, 4:49 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50491/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 4:49 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
>     https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved Network and NetworkProcess definitions into log/network.cpp.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3d33ee722543c67d0aa72e1c72c578066832331a 
>   src/log/network.hpp 8750880e6cecb6edf4efab4f2b9afe3d8a4d5964 
>   src/log/network.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50491/diff/
> 
> 
> Testing
> -------
> 
> see the end of review chain.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message