mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50490: Moved ZooKeeperNetwork into separate hpp and cpp files.
Date Wed, 27 Jul 2016 21:25:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50490/#review143808
-----------------------------------------------------------




src/Makefile.am (line 1220)
<https://reviews.apache.org/r/50490/#comment209744>

    You need one more tab.  Here and below.



src/log/network.hpp (line 27)
<https://reviews.apache.org/r/50490/#comment209737>

    This header should be moved over.
    
    Also, can you clean up the headers that are no longer needed in this file?



src/log/zookeeper/network.hpp (lines 19 - 21)
<https://reviews.apache.org/r/50490/#comment209739>

    By convention, we want to include all headers used within this file, even if the same
headers are included by another include.
    
    So, you'll want:
    ```
    #include <list>
    #include <set>
    #include <string>
    
    #include <mesos/zookeeper/group.hpp>
    
    #include <process/executor.hpp>
    #include <process/future.hpp>
    #include <process/pid.hpp>
    
    #include <stout/duration.hpp>
    #include <stout/option.hpp>
    ```



src/log/zookeeper/network.hpp (lines 43 - 50)
<https://reviews.apache.org/r/50490/#comment209741>

    Not yours, but can you remove the extra spaces in the `> >`?
    
    Three spots here and a couple more in `zookeeper/network.cpp`



src/log/zookeeper/network.cpp (lines 16 - 18)
<https://reviews.apache.org/r/50490/#comment209740>

    Same reason as above:
    
    ```
    #include <list>
    #include <set>
    #include <string>
    
    #include <mesos/zookeeper/group.hpp>
    
    #include <process/collect.hpp>
    #include <process/future.hpp>
    #include <process/pid.hpp>
    
    #include <stout/duration.hpp>
    #include <stout/foreach.hpp>
    #include <stout/lambda.hpp>
    #include <stout/option.hpp>
    #include <stout/set.hpp>
    ```


- Joseph Wu


On July 27, 2016, 4:49 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50490/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 4:49 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
>     https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved ZooKeeperNetwork declaration into log/zookeeper/network.hpp
> and definition into log/zookeeper/network.cpp.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3d33ee722543c67d0aa72e1c72c578066832331a 
>   src/log/log.cpp f8e439fc756af05acb40878a9473c93c039c889e 
>   src/log/network.hpp 8750880e6cecb6edf4efab4f2b9afe3d8a4d5964 
>   src/log/zookeeper/network.hpp PRE-CREATION 
>   src/log/zookeeper/network.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50490/diff/
> 
> 
> Testing
> -------
> 
> see the end of review chain
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message