mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 50528: Set allocation level explicitly instead of implicitly in v1 api tests.
Date Wed, 27 Jul 2016 21:19:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50528/#review143816
-----------------------------------------------------------


Ship it!




Ship It!

- Neil Conway


On July 27, 2016, 7:43 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50528/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 7:43 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5732
>     https://issues.apache.org/jira/browse/MESOS-5732
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As discussed with Neil, we are setting low allocation level
> for ReserveResources and UnreserveResources operator api v1
> tests explicitly instead of implicitly as it was set in 
> r50072. We are doing this to improve clarity in test cases.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 88523fdb3469c40b7ff71d5d753b645d20bc51bd 
> 
> Diff: https://reviews.apache.org/r/50528/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo GTEST_FILTER="*MasterAPITest.ReserveResources*:*MasterAPITest.UnreserveResources*"
make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message