mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.
Date Wed, 27 Jul 2016 17:47:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50488/#review143762
-----------------------------------------------------------




src/master/http.cpp (lines 2039 - 2051)
<https://reviews.apache.org/r/50488/#comment209694>

    It would be great if we don't duplicate code from [here](https://github.com/apache/mesos/blob/6d63c6236cec99a6ff79afd690c2287ccf3063eb/3rdparty/libprocess/src/http.cpp#L802).
    
    Actually it did work when you simply had `stringify(request.url)` and it looks like when
decoding the request on the server side the URL [doesn't include the scheme, host and port
part](https://github.com/apache/mesos/blob/6d63c6236cec99a6ff79afd690c2287ccf3063eb/3rdparty/libprocess/src/decoder.hpp#L153).
    
    If I am not missing anything, it does look like we can just use `stringify(request.url)`.
    
    BenM, you have a comment on [http.hpp](https://github.com/apache/mesos/blob/6d63c6236cec99a6ff79afd690c2287ccf3063eb/3rdparty/libprocess/include/process/http.hpp#L261),
is it possible that for server requests the URL is a full URI with scheme, host and port?
Doesn't look like it?


- Jiang Yan Xu


On July 27, 2016, 2:32 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50488/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 2:32 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Lunøe, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5911
>     https://issues.apache.org/jira/browse/MESOS-5911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the request which contains query parameters or fragment sent to a
> non-leading master, the master would redirect to an URL that ignored
> the query parameters and fragment. This changes the redirect URL
> include the query parameters or fragment.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1cbec976ccedae81def388c62889624aaf9a794e 
> 
> Diff: https://reviews.apache.org/r/50488/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message