mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50124: Added '--device' flag to mesos-docker-executor.
Date Wed, 27 Jul 2016 09:09:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50124/#review143697
-----------------------------------------------------------




src/docker/executor.hpp (lines 77 - 93)
<https://reviews.apache.org/r/50124/#comment209632>

    I would suggest you merge this to https://reviews.apache.org/r/50125/ as both of them
are for executor.



src/docker/executor.hpp (lines 81 - 82)
<https://reviews.apache.org/r/50124/#comment209606>

    1) I think here you mean `--device` but not `--devices`
    2) s/--devices/`--device`
    3) s/PathInHost:PathInContainer:Permission/`PathInHost:PathInContainer:Permission`



src/docker/executor.hpp (line 93)
<https://reviews.apache.org/r/50124/#comment209608>

    add `#include <string>` to the top of this file.



src/slave/containerizer/docker.cpp (line 1425)
<https://reviews.apache.org/r/50124/#comment209613>

    same comment as https://reviews.apache.org/r/50123/ , put the logic of `nvidiaGpus` to
a new patch


- Guangya Liu


On July 18, 2016, 9:20 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50124/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 9:20 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new flag '--device' to mesos-docker-executor to point out the
> devices can be accessed in docker container. Use the format
> PathInHost:PathInContainer:Permission and use comma to split multiple
> devices.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
>   src/slave/containerizer/docker.cpp f1ecf3b25d85597f6c3dcaa47968860ed119dbd5 
> 
> Diff: https://reviews.apache.org/r/50124/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message