mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).
Date Tue, 26 Jul 2016 22:55:13 GMT


> On July 26, 2016, 8:30 p.m., Greg Mann wrote:
> > Hi Yong,
> > Do you still have interest in getting this committed? If so, it looks like it needs
to be rebased.
> 
> Yong Tang wrote:
>     Thanks Greg. I tried to rebase but my local copy has been lost. Don't know how to
recover so I just created a new review request:
>     https://reviews.apache.org/r/50473/
>     
>     Please take a look and let me know if there are any issues.

Awesome, thanks Yong!!


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45011/#review143603
-----------------------------------------------------------


On March 18, 2016, 10:49 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45011/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Neil Conway, and Cong Wang.
> 
> 
> Bugs: MESOS-4070
>     https://issues.apache.org/jira/browse/MESOS-4070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix updated the implementation of numify() so that negative numbers
> could be handled conssitently for hex and non-hex numbers.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 26a637bec1193dd51437bd689c34fbe6d1935d89

>   3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp 444377df00922df12d4b3ed25b4cfe9071cff5c3

> 
> Diff: https://reviews.apache.org/r/45011/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message