mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 43569: Updated log message if container not found.
Date Tue, 26 Jul 2016 22:48:59 GMT


> On 七月 26, 2016, 8:29 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, line 379
> > <https://reviews.apache.org/r/43569/diff/6/?file=1311884#file1311884line379>
> >
> >     We put `+` in the end

Thanks Yu Jie, I saw that the `containerId` was already printted here https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L4029-L4033
, so seems I do not add `containerId` for such case. Will update this patch to only include
`containerId` for non `return Failure()` cases here.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/#review143602
-----------------------------------------------------------


On 三月 23, 2016, 1:50 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43569/
> -----------------------------------------------------------
> 
> (Updated 三月 23, 2016, 1:50 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated log message if container not found.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/containerizer/mesos/containerizer.cpp ee7a265975323ca891114a286357c8e42901560c

> 
> Diff: https://reviews.apache.org/r/43569/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message