mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yong Tang <yong.tang.git...@outlook.com>
Subject Review Request 50473: Fix numify() to handle negative numbers consistently (MESOS-4070).
Date Tue, 26 Jul 2016 22:47:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50473/
-----------------------------------------------------------

Review request for mesos, Greg Mann, Jie Yu, Neil Conway, and Cong Wang.


Bugs: MESOS-4070
    https://issues.apache.org/jira/browse/MESOS-4070


Repository: mesos


Description
-------

This fix updated the implementation of numify() so that negative numbers
could be handled conssitently for hex and non-hex numbers.


Diffs
-----

  3rdparty/stout/include/stout/numify.hpp 26a637bec1193dd51437bd689c34fbe6d1935d89 
  3rdparty/stout/tests/numify_tests.cpp 444377df00922df12d4b3ed25b4cfe9071cff5c3 

Diff: https://reviews.apache.org/r/50473/diff/


Testing
-------

make check (Ubuntu 14.04)

NOTE: This RR is from #45011.


Thanks,

Yong Tang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message