mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 50454: Fixed ExamplesTest.DiskFullFramework on non-root Linux builds.
Date Tue, 26 Jul 2016 21:02:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50454/#review143617
-----------------------------------------------------------


Ship it!




LGTM

- Anand Mazumdar


On July 26, 2016, 9 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50454/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 9 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-5907
>     https://issues.apache.org/jira/browse/MESOS-5907
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The example tests will check if an agent exits after two seconds, under
> the assumption that the agent fails fast if configured incorrectly.  
> On systems with systemd, the two second timeout may be insufficient
> as there is additional logic/validation for initializing systemd.
> 
> The test suite does not need systemd support in the first place, 
> so the agent launched in the DiskFullFramework example test should
> explicitly disable systemd logic.
> 
> 
> Diffs
> -----
> 
>   src/tests/disk_full_framework_test.sh 3fc180b3f1eaea91ff3c7d4fa8bf16e7278c55c4 
> 
> Diff: https://reviews.apache.org/r/50454/diff/
> 
> 
> Testing
> -------
> 
> Verified that the test passes on OSX and CentOS 7.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message