mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 50454: Fixed ExamplesTest.DiskFullFramework on non-root Linux builds.
Date Tue, 26 Jul 2016 20:37:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50454/#review143606
-----------------------------------------------------------



AFAICT, there are a couple of issues at play here:
- The test always failing on some distros.
- The test running forever due to a race condition.

It's not immediatly clear from the review description as to why disabling systemd helps with
the latter i.e. avoiding the race. Can you update the description to reflect that?

- Anand Mazumdar


On July 26, 2016, 8:31 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50454/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 8:31 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-5907
>     https://issues.apache.org/jira/browse/MESOS-5907
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test does not need systemd support and is not run as root.
> 
> 
> Diffs
> -----
> 
>   src/tests/disk_full_framework_test.sh 3fc180b3f1eaea91ff3c7d4fa8bf16e7278c55c4 
> 
> Diff: https://reviews.apache.org/r/50454/diff/
> 
> 
> Testing
> -------
> 
> Verified that the test passes on OSX and CentOS 7.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message