mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50088: Added mesos-protobuf target to build protobuf libraries.
Date Tue, 26 Jul 2016 00:54:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50088/#review142789
-----------------------------------------------------------


Ship it!




LGTM!

I'll fill in the commit description for you.  But make sure you take some time and fill in
the details in future!


src/CMakeLists.txt (line 494)
<https://reviews.apache.org/r/50088/#comment208538>

    We'll have to revisit the shared vs. static library thing later on.  This is fine on Linux/OSX,
but does not work on MSVC due to how it exports symbols from shared libraries.
    
    When we change to shared libraries (libmesos, libprocess, and libmesos-protobufs), we'll
need to use this CMake macro:
    https://cmake.org/cmake/help/latest/module/GenerateExportHeader.html
    
    Alex and I will most likely handle this part.



src/CMakeLists.txt (line 508)
<https://reviews.apache.org/r/50088/#comment208419>

    I'll fix this up before committing:
    
    `MESOS_TARGET` needs to link against `MESOS_PROTOBUF_TARGET` too.


- Joseph Wu


On July 18, 2016, 3:59 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50088/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 3:59 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5852
>     https://issues.apache.org/jira/browse/MESOS-5852
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added mesos-protobuf target to build protobuf libraries.
> 
> 
> Diffs
> -----
> 
>   cmake/MesosConfigure.cmake b2318ed8eb4e11de43abfc15f51d12b2c0ff8fa1 
>   src/CMakeLists.txt bde76f7840afe55f20d7551b3f7e5fe522f7f326 
> 
> Diff: https://reviews.apache.org/r/50088/diff/
> 
> 
> Testing
> -------
> 
> cmake .. && make mesos-protobufs
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message