mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 50413: Minor cleanups to the command executor.
Date Tue, 26 Jul 2016 00:35:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50413/#review143456
-----------------------------------------------------------



Patch looks great!

Reviews applied: [50410, 50411, 50412, 50413]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 25, 2016, 9:35 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50413/
> -----------------------------------------------------------
> 
> (Updated July 25, 2016, 9:35 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change does a few minor cleanups:
> - Renamed `taskID` -> `taskId`
> - Renamed `taskId` argument to `_taskId` to avoid confusion
> with the member variable `taskId`.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 5a5f95f04a6ce096079b67397cb324575409f795 
> 
> Diff: https://reviews.apache.org/r/50413/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message