-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46626/#review143444
-----------------------------------------------------------
Fix it, then Ship it!
I'm going to modify your commit description before committing :)
Also, I've made a couple small tweaks before committing, which are noted below.
src/examples/disk_full_framework.cpp (line 19)
<https://reviews.apache.org/r/46626/#comment209232>
This is not used.
src/examples/disk_full_framework.cpp (line 40)
<https://reviews.apache.org/r/46626/#comment209231>
This is out of order.
Also missing `<stout/duration.hpp>` and `<stout/try.hpp>`
src/examples/disk_full_framework.cpp (line 44)
<https://reviews.apache.org/r/46626/#comment209230>
This seems to be un-used.
src/examples/disk_full_framework.cpp (line 306)
<https://reviews.apache.org/r/46626/#comment209233>
Typo: `frameowork`
src/examples/disk_full_framework.cpp (line 362)
<https://reviews.apache.org/r/46626/#comment209237>
`*` on the wrong side of the space.
src/examples/disk_full_framework.cpp (line 391)
<https://reviews.apache.org/r/46626/#comment209239>
`*` on the wrong side of the space.
- Joseph Wu
On July 25, 2016, 12:22 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46626/
> -----------------------------------------------------------
>
> (Updated July 25, 2016, 12:22 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-5855
> https://issues.apache.org/jira/browse/MESOS-5855
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added example framework for testing disk quota enforcement.
>
>
> Diffs
> -----
>
> src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d
> src/examples/disk_full_framework.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
|