mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 50415: Added build step to build Java Protobuf.
Date Mon, 25 Jul 2016 22:47:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50415/#review143443
-----------------------------------------------------------



Patch looks great!

Reviews applied: [50414, 50415]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 25, 2016, 10:31 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50415/
> -----------------------------------------------------------
> 
> (Updated July 25, 2016, 10:31 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
>     https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is similar external project build in parallel to normal 
> probuf build for c++. I preferred to use "-java" prefix to 
> separate the project build.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 770a3828a6e0ffaa4f185392fdc1a2152446449d 
> 
> Diff: https://reviews.apache.org/r/50415/diff/
> 
> 
> Testing
> -------
> 
> cmake && make protobuf-2.6.1-java 
> check if 3rdparty/protobuf-2.6.1/src/protobuf-2.6.1-java/java/target/protobuf-java-2.6.1.jar
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message