-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50338/#review143371
-----------------------------------------------------------
Ship it!
on Ubuntu 16.04: `./mesos-tests --gtest_break_on_failure --gtest_repeat=10000 --gtest_filter="SlaveAuthorizerTest/*.ViewFlags"`
Before applying the patch the issue could be reproduced, but not after the patch.
- Alexander Rojas
On July 22, 2016, 3:35 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50338/
> -----------------------------------------------------------
>
> (Updated July 22, 2016, 3:35 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Vinod Kone.
>
>
> Bugs: MESOS-5888
> https://issues.apache.org/jira/browse/MESOS-5888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in SlaveAuthorizerTest.ViewFlags.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp f76ed3a4c77ba4109d1b9e2083bd3dfbfef41b43
>
> Diff: https://reviews.apache.org/r/50338/diff/
>
>
> Testing
> -------
>
> `make check`
>
> Validated that with this change, slave recovery always finishes before any of the subsequent
HTTP requests are sent. Note that I couldn't actually trigger the test case failure on my
machine.
>
> If there's a more precise way to have the test case wait for the slave to finish recovery,
let me know.
>
>
> Thanks,
>
> Neil Conway
>
>
|