-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50181/
-----------------------------------------------------------
(Updated July 25, 2016, 1:41 a.m.)
Review request for mesos, Anand Mazumdar, Jay Guo, and Vinod Kone.
Changes
-------
Add `Testing Done`.
Summary (updated)
-----------------
Fixed the flaky test case `MasterAPITest.GetTasks`.
Bugs: MESOS-5860
https://issues.apache.org/jira/browse/MESOS-5860
Repository: mesos
Description
-------
This changes to wait for every `StatusUpdateAcknowledgementMessage`
exactly in this test case to make sure they don't conflict each other.
Diffs (updated)
-----
src/tests/api_tests.cpp 88523fdb3469c40b7ff71d5d753b645d20bc51bd
Diff: https://reviews.apache.org/r/50181/diff/
Testing (updated)
-------
Before apply the patch, could reproduce by
```
$ stress --cpu 4 --timeout 3600s &
$ GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*MasterAPITest.GetTasks*" --gtest_break_on_failure
--gtest_repeat=-1 --verbose
```
After apply the patch, could not reproduce by
```
$ stress --cpu 4 --timeout 3600s &
$ GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*MasterAPITest.GetTasks*" --gtest_break_on_failure
--gtest_repeat=-1 --verbose
```
So verified this patch resolve the flaky.
Thanks,
haosdent huang
|