mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 50338: Fixed flakiness in SlaveAuthorizerTest.ViewFlags.
Date Sun, 24 Jul 2016 20:09:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50338/#review143340
-----------------------------------------------------------



Looks much more simpler than what we discussed with the guys in the office (which is the reason
I didn't propose a patch yet). The error occurs in Linux only so I will try it and then give
it a ship it if it solves the issue.

- Alexander Rojas


On July 22, 2016, 3:35 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50338/
> -----------------------------------------------------------
> 
> (Updated July 22, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Bugs: MESOS-5888
>     https://issues.apache.org/jira/browse/MESOS-5888
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed flakiness in SlaveAuthorizerTest.ViewFlags.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_authorization_tests.cpp f76ed3a4c77ba4109d1b9e2083bd3dfbfef41b43 
> 
> Diff: https://reviews.apache.org/r/50338/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Validated that with this change, slave recovery always finishes before any of the subsequent
HTTP requests are sent. Note that I couldn't actually trigger the test case failure on my
machine.
> 
> If there's a more precise way to have the test case wait for the slave to finish recovery,
let me know.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message