mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.
Date Sun, 24 Jul 2016 13:56:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49827/#review143332
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 540 - 546)
<https://reviews.apache.org/r/49827/#comment209115>

    I do not think we need this `onAny()` call.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 551)
<https://reviews.apache.org/r/49827/#comment209117>

    I do not think you need this parameter.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 557)
<https://reviews.apache.org/r/49827/#comment209118>

    Ditto.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 560)
<https://reviews.apache.org/r/49827/#comment209119>

    Suggest to add a newline before this line.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 570 - 575)
<https://reviews.apache.org/r/49827/#comment209120>

    I would suggest to change these code to:
    ```
      return collect(futures)
        .then(defer(PID<CgroupsIsolatorProcess>(this),
                    &CgroupsIsolatorProcess::__cleanup,
                    containerId))
    ```
    And to make the above code work, we also need to change the return value of `__cleanup`
from `void` to `Future<Nothing>`. You may take a look at the following code as a reference:
    https://github.com/apache/mesos/blob/1.0.0-rc4/src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp#L627:L634


- Qian Zhang


On July 22, 2016, 3:11 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49827/
> -----------------------------------------------------------
> 
> (Updated July 22, 2016, 3:11 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `CgroupsIsolatorProcess::cleanup`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp c57baec88437f68886702a40ec8a6a6458546119

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 4a9f55bf3b217405bf90943f27a976422877a99e

> 
> Diff: https://reviews.apache.org/r/49827/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message