mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.
Date Sun, 24 Jul 2016 01:05:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49814/#review142601
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 59)
<https://reviews.apache.org/r/49814/#comment208223>

    I would simply just kill this temp var and inline `"cgroups/"` in the following code.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 56)
<https://reviews.apache.org/r/49814/#comment209098>

    Please add a comment about what is key and what is value since it's not quite obvious.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 61)
<https://reviews.apache.org/r/49814/#comment209095>

    s/type/isolator/



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 75 - 78)
<https://reviews.apache.org/r/49814/#comment209097>

    I would simply inline `prepareHierarchy` here. Is this helper used elsewhere?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 87)
<https://reviews.apache.org/r/49814/#comment209096>

    s/create/subsystem/



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 112 - 117)
<https://reviews.apache.org/r/49814/#comment209099>

    I'd suggest we use the same subsystem name as that in the kernel. We can deprecate some
existing name (e.g., use cgroups/memory forward and deprecate cgroups/mem).



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 116)
<https://reviews.apache.org/r/49814/#comment209103>

    Please avoid using non-POD global variables because it might cause issues during tear
down. Simply remove `static` here.


- Jie Yu


On July 21, 2016, 7:04 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49814/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `CgroupsIsolatorProcess::create`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp c57baec88437f68886702a40ec8a6a6458546119

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 4a9f55bf3b217405bf90943f27a976422877a99e

> 
> Diff: https://reviews.apache.org/r/49814/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message