mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 50362: Added an appropriate content type for the /help endpoints.
Date Fri, 22 Jul 2016 22:24:02 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 22, 2016, 3:24 p.m.)

Review request for mesos, Anand Mazumdar, Greg Mann, and Artem Harutyunyan.


Use the other constructor of `HTTP::OK`.

Repository: mesos


The `Content-Type` header was set to "text/plain" by default in all
responses here:

This had the adverse consequence of changing the `/help` endpoints
into plain text.  Previously, the browser would see some `<html>`
tags and assume the content was HTML.

Diffs (updated)

  3rdparty/libprocess/src/help.cpp 5bb1ddd8ae4c180972e91b4b4ac6d83d65c4a4b0 



Started a master and hit `/help` and `/help/master`.  Confirmed that I did not get a wall
of javascript in plain text.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message