mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 50357: Removed a redundant CLOEXEC from linux/ns.hpp.
Date Fri, 22 Jul 2016 22:15:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50357/#review143284
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On July 22, 2016, 9:17 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50357/
> -----------------------------------------------------------
> 
> (Updated July 22, 2016, 9:17 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, Artem Harutyunyan, Ian Downes,
and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The call to `os::open` that creates the FD includes O_CLOEXEC.
> This will set CLOEXEC on the FD before `os::open` returns.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp 4e843b7835f44418b79a0b38e3d66aa30e68f700 
> 
> Diff: https://reviews.apache.org/r/50357/diff/
> 
> 
> Testing
> -------
> 
> make check (CentOS 7)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message