mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 50062: Refactored `makePortRanges` for allocator benchmark test.
Date Fri, 22 Jul 2016 19:10:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50062/#review143254
-----------------------------------------------------------


Ship it!




Modulo similar feedback from: https://reviews.apache.org/r/50172/

- Benjamin Mahler


On July 21, 2016, 2:07 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50062/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 2:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch refactored the helper function of `makePortRanges` as this:
> 
> 1) Renamed `makePortRanges` to `makePorts`, this function creates a
>    "ports(*)" resource for the given ranges.
> 2) Added a new helper function `fragment`, it helps to fragments the
>    given range bounds into a number of subranges.
> 3) Keep `makeRange` unchanged but updated its parameter using `uint64_t`.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp befb94adb15e051abae135c7697538bd0cf83852

> 
> Diff: https://reviews.apache.org/r/50062/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message