mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 50301: Reduced logging verbosity for replicated log operations.
Date Thu, 21 Jul 2016 23:07:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50301/#review143150
-----------------------------------------------------------



Patch looks great!

Reviews applied: [50301]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 21, 2016, 4:26 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50301/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 4:26 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Logging the duration required for each storage operation at `INFO` level
> is overkill for most people consuming the log.
> 
> 
> Diffs
> -----
> 
>   src/log/leveldb.cpp f389d74b123574665c611b46cb52e3dc7042b331 
>   src/log/log.cpp f8e439fc756af05acb40878a9473c93c039c889e 
>   src/log/replica.cpp 45b77178fe93e26ae0ffde5ff0f02f36e5150bcb 
>   src/master/registrar.cpp 9d2f5580c7a8674f29b4c2be0142689f000d15a0 
> 
> Diff: https://reviews.apache.org/r/50301/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also visual inspection: ran a few `--verbose` test cases and checked that the omitted
information wasn't necessary/useful for understanding the replicated log activity.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message