mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 50285: Replaced boost::lexical_cast with numify when paring Value.
Date Thu, 21 Jul 2016 19:07:10 GMT


> On July 21, 2016, 7:05 p.m., Benjamin Mahler wrote:
> > Ship It!

Note that you have a typo in the commit summary. (paring -> parsing)


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50285/#review143128
-----------------------------------------------------------


On July 21, 2016, 6:52 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50285/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 6:52 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced boost::lexical_cast with numify when paring Value.
> 
> 
> Diffs
> -----
> 
>   src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 
>   src/v1/values.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e 
> 
> Diff: https://reviews.apache.org/r/50285/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message