mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 50072: Speed up reservation test by setting allocation interval in master flags.
Date Tue, 19 Jul 2016 22:49:00 GMT


> On July 19, 2016, 10:46 p.m., Vinod Kone wrote:
> > src/tests/api_tests.cpp, lines 95-97
> > <https://reviews.apache.org/r/50072/diff/3-4/?file=1445651#file1445651line95>
> >
> >     I'll clean up the coment while committing.

Why do we want to change this for all the tests? As pointed out by Neil here: https://reviews.apache.org/r/49914/#comment207529
we should be inlining and changing this for only the tests that _need_ it.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50072/#review142859
-----------------------------------------------------------


On July 19, 2016, 8:47 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50072/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 8:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5732
>     https://issues.apache.org/jira/browse/MESOS-5732
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> ReserveResource test (and UnreserveResource test) in v1 operator
> API is very slow and taking more than 1000 ms. If we set allocation
> interval in master flag to 50ms and use that flag to start up a
> master to use in the test, we can reduce the duration time for
> that test as low as 120 ms. So, in this patch we made that change.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp b4bee76 
> 
> Diff: https://reviews.apache.org/r/50072/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message