mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 49617: Add benchmark for failover of many frameworks.
Date Tue, 19 Jul 2016 16:48:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/#review142075
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (line 3690)
<https://reviews.apache.org/r/49617/#comment208340>

    A blank line above.



src/tests/hierarchical_allocator_tests.cpp (line 3706)
<https://reviews.apache.org/r/49617/#comment208339>

    A blank line above.



src/tests/hierarchical_allocator_tests.cpp (lines 3709 - 3710)
<https://reviews.apache.org/r/49617/#comment208335>

    Empty lines above and below.



src/tests/hierarchical_allocator_tests.cpp (line 3717)
<https://reviews.apache.org/r/49617/#comment208336>

    The std::min above already makes sure batchEnd is at most frameworkCount so we don't need
to worry about i < frameworkCount here.



src/tests/hierarchical_allocator_tests.cpp (lines 3721 - 3723)
<https://reviews.apache.org/r/49617/#comment208346>

    Add to the end: `, thus a separate loop.` so it's more clear?


- Jiang Yan Xu


On July 7, 2016, 8:11 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49617/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 8:11 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5780
>     https://issues.apache.org/jira/browse/MESOS-5780
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - This benchmark measures latency to stability of
>   the allocator following disconnection and
>   reconnection of all frameworks.
> - In this scenario, frameworks are offered resources
>   and suppressed in batches.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179

> 
> Diff: https://reviews.apache.org/r/49617/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message