mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 50184: Fixed length argument bug when reading file.
Date Tue, 19 Jul 2016 11:40:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50184/#review142726
-----------------------------------------------------------



Patch looks great!

Reviews applied: [50184]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 19, 2016, 7:51 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50184/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 7:51 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If length provided by client is bigger than
> (size - offset), the data returned by read
> file API should only contain the data actually
> read from the file. Now, a length long string
> will be returned which may contain blank characters.
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp 8ab8f8aad9cfe1e536b29e8994fcd8599627e590 
>   src/tests/api_tests.cpp b4bee760cbc5cc90b488554f58daf23b7482d915 
> 
> Diff: https://reviews.apache.org/r/50184/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> run mesos-master with --log_dir or --external_log_file specified. 
> Open a browser and goto 127.0.0.1:5050, click 'LOG' link on the home page.
> The log of master shall be shown and updated correctly.
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message