mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 50072: Set allocation interval in 'Master Flags' for operator API reservation tests.
Date Tue, 19 Jul 2016 06:55:31 GMT


> On July 19, 2016, 12:51 a.m., Vinod Kone wrote:
> > src/tests/api_tests.cpp, lines 946-1041
> > <https://reviews.apache.org/r/50072/diff/3/?file=1445651#file1445651line946>
> >
> >     Why this change? The context is not clear from the description or the ticket.

My bad. MasterFlags should not be placed here. But class MasterAPITest should look like this
as it was in my first version: 
class MasterAPITest
  : public MesosTest,
    public WithParamInterface<ContentType>
{
public:
  // Set up the master flags such that it allows registration of the framework
  // created with 'createFrameworkInfo'.
  virtual master::Flags CreateMasterFlags()
  {
    master::Flags flags = MesosTest::CreateMasterFlags();
    flags.allocation_interval = Milliseconds(50);
    flags.roles = createFrameworkInfo().role();
    return flags;
  }
  ----
So here are results of RerverResource before and after making this change:

Before change:
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from ContentType/MasterAPITest
[ RUN      ] ContentType/MasterAPITest.ReserveResources/0
[       OK ] ContentType/MasterAPITest.ReserveResources/0 (1054 ms)
[ RUN      ] ContentType/MasterAPITest.ReserveResources/1
[       OK ] ContentType/MasterAPITest.ReserveResources/1 (1036 ms)
[----------] 2 tests from ContentType/MasterAPITest (2097 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (2103 ms total)
[  PASSED  ] 2 tests.

After change:
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from ContentType/MasterAPITest
[ RUN      ] ContentType/MasterAPITest.ReserveResources/0
[       OK ] ContentType/MasterAPITest.ReserveResources/0 (149 ms)
[ RUN      ] ContentType/MasterAPITest.ReserveResources/1
[       OK ] ContentType/MasterAPITest.ReserveResources/1 (129 ms)
[----------] 2 tests from ContentType/MasterAPITest (286 ms total)


So, should I go ahead with the above mentioned change and change the description of this review?
Btw, I am putting you as reviewer of this patch.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50072/#review142673
-----------------------------------------------------------


On July 18, 2016, 8:16 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50072/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 8:16 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Neil Conway.
> 
> 
> Bugs: MESOS-5725
>     https://issues.apache.org/jira/browse/MESOS-5725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set allocation interval in 'Master Flags' for operator
> API reservation tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 37bf2866e1dbf7a8bead0c93825666921f4228fb 
> 
> Diff: https://reviews.apache.org/r/50072/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message