mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 50177: Add systemd watchdog support.
Date Tue, 19 Jul 2016 06:07:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50177/#review142695
-----------------------------------------------------------



Bad patch!

Reviews applied: [50177]

Failed command: ./support/apply-review.sh -n -r 50177

Error:
2016-07-19 06:07:28 URL:https://reviews.apache.org/r/50177/diff/raw/ [3485/3485] -> "50177.patch"
[1]
Total errors found: 0
Checking 3 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/14382/console

- Mesos ReviewBot


On July 19, 2016, 1:14 a.m., Lawrence Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50177/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 1:14 a.m.)
> 
> 
> Review request for mesos, David Robinson and Ian Downes.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds systemd watchdog support (see http://0pointer.de/blog/projects/watchdog.html for
context).
> 
> 
> Diffs
> -----
> 
>   configure.ac d2136909b7305498ae901a5ea00133142b77f9e6 
>   src/linux/systemd.hpp 91134f1d4b100759e45931bd09ca4e1e1aeaaf8a 
>   src/linux/systemd.cpp 619aa2778da5f99d3a078a8e1208bdaa9dc77581 
>   src/slave/main.cpp 4624392d30cf391015dcd63f447fe2414a47a16a 
> 
> Diff: https://reviews.apache.org/r/50177/diff/
> 
> 
> Testing
> -------
> 
> Tested by sending SIGSTOP to running mesos and verifying via journalctl that it was killed
by the watchdog.
> 
> TODO: write actual test by using and forking a mock binary that initializes systemd and
sending SIGSTOP to that binary. test also needs a unit file for that binary and for systemd
to run so we can verify that systemd killed it.
> 
> 
> File Attachments
> ----------------
> 
> mesos gets owned by watchdog
>   https://reviews.apache.org/media/uploaded/files/2016/07/19/3c73b595-d28e-45d4-adfe-697801ba02cc__Screen_Shot_2016-07-18_at_2.09.31_PM.png
> 
> 
> Thanks,
> 
> Lawrence Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message