mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.
Date Tue, 19 Jul 2016 00:49:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49913/#review142672
-----------------------------------------------------------




src/tests/mesos.hpp (lines 610 - 615)
<https://reviews.apache.org/r/49913/#comment208304>

    I think a generic `createFrameworkInfo()` that returns DEFAULT_FRAMEWORK_INFO with "role1"
is unintuitive for callers. How would they know they get "role1" FrameworkInfo?
    
    I wouldn't do this change.


- Vinod Kone


On July 18, 2016, 8:11 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49913/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 8:11 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5725
>     https://issues.apache.org/jira/browse/MESOS-5725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There were multiple createFrameworkInfo() definition scattered
> in various testcases. In this patch, only one defintion of
> createFrameworkInfo() is provided in src/tests/mesos.hpp and
> other tests just used this definition.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 37bf2866e1dbf7a8bead0c93825666921f4228fb 
>   src/tests/mesos.hpp e4eccfc3810bed3649a3ab80e252849470de4c72 
>   src/tests/persistent_volume_endpoints_tests.cpp 2a22f3b0da817e650a25e5e2c951adb7462718b4

>   src/tests/reservation_endpoints_tests.cpp 48c002d1dc371c285b9421ef5a2c57250d270fa8

> 
> Diff: https://reviews.apache.org/r/49913/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message