mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 50147: Simplified the checkpointed resources handling logic.
Date Mon, 18 Jul 2016 21:14:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50147/#review142640
-----------------------------------------------------------



Patch looks great!

Reviews applied: [50147]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 18, 2016, 5:42 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50147/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 5:42 p.m.)
> 
> 
> Review request for mesos, Anindya Sinha and Neil Conway.
> 
> 
> Bugs: MESOS-5448
>     https://issues.apache.org/jira/browse/MESOS-5448
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently we always checkpoint resources.target and in the agent
> recovery path we have to handle the target being the same as the
> committed resources.info. If we don't create the target when the new
> checkpointed resources are the same, then we don't need to worry about
> that possibility in recovery.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp dc619eb72703d8f168defa120183b2c50ae38d5c 
> 
> Diff: https://reviews.apache.org/r/50147/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message