mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 43471: Added the zookeeper patch for the slow add_auth calls.
Date Mon, 18 Jul 2016 21:05:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43471/#review142634
-----------------------------------------------------------



Thanks for tracking down the slowness issue.

I'm a bit hesitant to pull in this patch without it being upstreamed yet. Have you tried asking
on their mailing list if they can pick it back up?

- Benjamin Mahler


On July 16, 2016, 2:09 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43471/
> -----------------------------------------------------------
> 
> (Updated July 16, 2016, 2:09 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-4648
>     https://issues.apache.org/jira/browse/MESOS-4648
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the zookeeper patch for the slow add_auth calls.
> 
> 
> Diffs
> -----
> 
>   3rdparty/zookeeper-06d3f3f.patch be2ceaf529895c92dcf53984d6d88c78fb1d74ec 
>   3rdparty/zookeeper-3.4.8.patch 486df1ae96af3426835c9d47ff2e36dd47ccde3f 
> 
> Diff: https://reviews.apache.org/r/43471/diff/
> 
> 
> Testing
> -------
> 
> Before
> 
> ```
> [       OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (10053 ms)
> [       OK ] MasterZooKeeperTest.MasterInfoAddress (11282 ms)
> [       OK ] ZooKeeperTest.Auth (6688 ms)
> [       OK ] ZooKeeperTest.Create (6690 ms)
> ```
> 
> After
> 
> ```
> [       OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (321 ms)
> [       OK ] MasterZooKeeperTest.MasterInfoAddress (447 ms)
> [       OK ] ZooKeeperTest.Auth (233 ms)
> [       OK ] ZooKeeperTest.Create (275 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message